Will Holmgren

Personally I would recommend posting those files somewhere online (zenodo?), removing them from the distribution, and forcing users to manually specify a file path. (I think this is similar to...

I also like the solar_ prefix. I'd prefer to refer to the apparent/refracted zenith as solar_zenith. solar_apparent/refracted_zenith is fine too, though. Perhaps the current "zenith" becomes solar_unrefracted_zenith? I don't like...

So are we in agreement with https://github.com/pvlib/pvlib-python/issues/1403#issuecomment-1043363825 except for the geom/analytical name? I generally agree with @mikofski on the descriptor order but we already have the `solar_zenith_analytical` function and I...

The vast majority of these will be positional arguments, in which case I say no deprecation is needed. If there are any keyword arguments then yes, you've got the right...

Ohhh yea great point @kanderso-nrel. Changing column names might be the most user-hostile thing we've ever done. I think we should do it and it should be in 0.10.0 rather...

> It looks like it is used to illustrate how the functions/methods are implemented (i.e.: to show the source code of the function). @wholmgren was that the intention? Yes. Have...

My impression is that ipython directive was largely abandoned for at least a few years as development focused on notebooks and then jupyter lab. It's been a little finicky. Maybe...

Thanks @Naman-Priyadarshi, that would be great. Yes to both of your questions.

> It would be nice if the method runs without requiring these attributes. Isn't the problem that the method must be specified when the `ModelChain` object is instantiated? If so,...

Following the patterns in some other `iotools` modules, I'll suggest 1. refactoring the io components out of `read_surfrad` so that it only performs the parsing and 2. making a new...