pvlib-python icon indicating copy to clipboard operation
pvlib-python copied to clipboard

update `benchmarks/tracking.py` for `SingleAxisTracker` deprecation

Open wholmgren opened this issue 2 years ago • 2 comments

Describe the bug SingleAxisTracker is deprecated, but the tracking.py benchmark still uses it:

https://github.com/pvlib/pvlib-python/blob/3f397ed44075b01f4ba535750356859195a51b2d/benchmarks/benchmarks/tracking.py#L20

To Reproduce run asv tests. or look at the asv quick CI output

Expected behavior no deprecation warnings in the benchmark test suite

Screenshots If applicable, add screenshots to help explain your problem.

Versions:

  • pvlib.__version__: 0.9. https://github.com/pvlib/pvlib-python/pull/1507

wholmgren avatar Jul 29 '22 19:07 wholmgren

I wanted to work on the issue! Should i just remove the time_tracker_singleaxis function from the benchmark file?

Also when running asv dev I noticed that some of the benchmarking functions were failing, should i open a new issue regarding the same?

Naman-Priyadarshi avatar Aug 05 '22 21:08 Naman-Priyadarshi

Thanks @Naman-Priyadarshi, that would be great. Yes to both of your questions.

wholmgren avatar Aug 12 '22 18:08 wholmgren