Jeff Whiting

Results 9 comments of Jeff Whiting

Both this PR and https://github.com/docker/kitematic/pull/4401 provide the ability to define custom volumes. It would be awesome if one of those implementations were chosen and merged. This is a much needed...

I've updated the PR to address your concern. Node.js 0.10 will never call the callbacks. I also updated the tests to assert that no callbacks were happening (that test failed...

I've read through your comment. I've have been thinking a lot about it and doing some research. The good news is that both `spdy` (https://github.com/indutny/node-spdy#api) and `http2` (https://github.com/molnarg/node-http2/blob/master/lib/http.js#L1092) use `http.OutgoingMessage`...

I've removed the version bump from the PR. I also implemented the first approach of throwing an error in a separate branch in my repo to see what it would...

You're right. When I read the code I didn't realize `OutgoingMessage` was defined in the file and not coming from `http.OutgoingMessage`. Regardless they are attempting to maintain the same API...

Your approach sounds reasonable. I understand being conservative with changes as so many different apps use this module. I'll update the PR to assume that there is callback support for...

@dougwilson thanks for being so responsive on this thread. I've updated the PR to just pass through the callbacks. I didn't update the `node` version in `package.json` as I figured...

I'm having the exact opposite problem with the same keyboard. Logitech options+ is in control and karabiner seems to be ignored. I can make modifications for my macbook keyboard but...

+1 Please let me remove it