Chris White

Results 128 issues of Chris White

We were missing some global flags in `CachedCMakePackage`, so I took the logic (with minor tweaks) from `CMakePackage`.

build-systems
core

We should help with exporting CMake targets better. The following two ideas were proposed: 1. Add export options to `blt_add_library`, for example, export namespace and export set name. This could...

e.g. clangformat, clangtidy, doxygen, etc. This seems to be causing more problems then its solving. Originally it was thought that these were safe to be turned on by default because...

code checks

This removes the old deprecated FindCUDA and mimic's what @davidbeckingsale did for HIP support. Breaking changes: - `cuda` -> `blt::cuda` - `cuda_runtime` -> `blt::cuda_runtime` - `CMAKE_LINK_WITH_NVCC` -> `BLT_CMAKE_LINK_WITH_NVCC` (warning about...

In all host-configs we set both `CMAKE_CUDA_ARCHITECTURES` and add the `-arch` flag manually to the `CMAKE_CUDA_FLAGS`. Why is does this seem to be necessary? Is it possibly our reliance on...

To reproduce start a pipeline and watch it ask for allocations in both `corona_allocate` and `quartz_allocate` then again for each build job.

https://github.com/LLNL/blt/blob/develop/cmake/thirdparty/SetupCUDA.cmake#L85

Having a variable in the `DEPENDS_ON` list of `blt_add_executable` causes all dependencies to not be set in the `LINK_LIBRARIES` target property. Reproducer: ``` cmake_minimum_required(VERSION 3.3) project(test) set(BLT_SOURCE_DIR "/usr/workspace/white238/blt/repo") include(${BLT_SOURCE_DIR}/SetupBLT.cmake) blt_import_library(NAME...

bug
User Request

These should be documented on their own page: https://github.com/LLNL/blt/blob/1720b660fcdc121b68d370444f192be5c3db1ceb/SetupBLT.cmake#L175-L182 There may be more.

documentation

https://github.com/LLNL/blt/blob/develop/cmake/BLTOptions.cmake All of these options need to be documented in their own page.

documentation