blt icon indicating copy to clipboard operation
blt copied to clipboard

WIP: Revamp CUDA support

Open white238 opened this issue 2 years ago • 3 comments

This removes the old deprecated FindCUDA and mimic's what @davidbeckingsale did for HIP support.

Breaking changes:

  • cuda -> blt::cuda
  • cuda_runtime -> blt::cuda_runtime
  • CMAKE_LINK_WITH_NVCC -> BLT_CMAKE_LINK_WITH_NVCC (warning about former being deprecated)
  • Removes Clang CUDA support (does anyone still use this @davidbeckingsale ?)

Thanks to @kennyweiss for sitting on a webex while I drastically rip support out from under myself!

white238 avatar Jun 17 '22 02:06 white238

@white238 will this require a syntax change for BLT users like the recent change in HIP support; e.g., 'cuda_runtime' --> 'cuda::runtime'?

rhornung67 avatar Jun 17 '22 17:06 rhornung67

@white238 will this require a syntax change for BLT users like the recent change in HIP support; e.g., 'cuda_runtime' --> 'cuda::runtime'?

Yes this is a breaking change in the following ways:

cuda -> blt::cuda cuda_runtime -> blt::cuda_runtime CMAKE_LINK_WITH_NVCC -> BLT_CMAKE_LINK_WITH_NVCC

white238 avatar Jun 17 '22 18:06 white238

We should probably add this to the blt::cuda target:

https://cmake.org/cmake/help/latest/module/FindCUDAToolkit.html#cuda-driver-library

white238 avatar May 16 '23 17:05 white238