Henrik Skupin

Results 533 comments of Henrik Skupin

Maybe we use a wording for the label similar to Bugzilla's whiteboard entry? Something like 'good first issue'?

Maybe the bug status is still assigned? People tend to forget to also set this back to new.

@Kujo-Jotaro-AAAAA you should await the call to `page.goto`. Does that fix the issue for you?

> TimeoutError: Navigation timeout of 30000 ms exceeded > > 56 | case 2: > 57 | page = _a.sent(); > > 58 | return [4, page.goto('http://localhost:1234', { > |...

I don't see that you have set the mentioned Firefox preference. The log output should then give way more lines. And I would need a bit more than just this...

@realivanjx which URL are you navigating to? Is it causing a COOP navigation? See https://github.com/puppeteer/puppeteer/issues/8385#issuecomment-1135470259 in how to generate a log file that could be used to further investigate the...

Moving to draft for now because I would like to do some experiments, which might trigger to a backout of https://github.com/puppeteer/puppeteer/commit/e7f82626cabeb997a95e865a9b58353310c8a9c7 (PR #7610).

Forcing Fission disabled doesn't actually fix the test. So some other change that I might have done recently in Firefox might have caused it. I'll check with custom Firefox builds...

The problem that we currently have with Windows is that Firefox uses a launcher process that initially gets started, and then itself launches the real Firefox process. As such Puppeteer...

> @whimboo thanks for the info, can we disable that test for FireFox on Windows for now? It might not be only a single test. Basically each test that causes...