Steffen Winterfeldt

Results 9 comments of Steffen Winterfeldt

I'll take some time to look trough it all. So far: - I agree, the `VERSION` handling is not ideal; I've changed it a bit in some of my other...

Just a heads-up: I haven't forgotten...

This looks like a great idea! Sure, make a pull request. > Also, is licensing on this project is OSI approved? https://opensource.org/licenses/BSD-3-Clause

OK, from looking at it so far, 3 things: 1. please separate out the one-line functional chage (32 bit stack) 2. there's a huge amount of white-space changes, please do...

I find it usually easiest in these situations to go back with 'git reset' and then use 'git add -p' to re-structure the changes. And it's perfectly fine to use...

> I don't understand the virtual memory system very well at all especially for stack usage. Actually, I misread your original [comment](https://github.com/wfeldt/libx86emu/issues/25#issuecomment-636510177). I assumed you were still talking about x86emu-demo.c....

This is not the question. I agree that the demo code should also enable 32-bit mode for the stack segment if --32 is used. What I'm saying is that your...

> I made the correct changes to the correct file this time. Kind of; there's still the original commit; and the file you changed got added to the wrong directory....