libx86emu
libx86emu copied to clipboard
Improve Makefile
These changes were inspired by hwinfo
s Makefile and by the GNU make manual.
The current version detection system and the changelog are fully dependent on git. This complicates building from release archives. One of my commits adds the LIBX86EMU_VERSION
variable that makes things simpler, but this is not a good solution in my opinion. Another solution to this problem is to add a VERSION
file that would be incremented on every release. This wouldn't change the logic that much since Makefile already uses VERSION
.
And while we're here, I'll ask some questions: Is the $(ARCH)
variable used for anything in the current version of libx86emu
s Makefile and do you have any specific reason to use /usr/lib64
instead of /usr/lib
?
I'll take some time to look trough it all. So far:
- I agree, the
VERSION
handling is not ideal; I've changed it a bit in some of my other projects - I don't really like
.gitignore
and I'd rather remove it instead of extending; IMHO a 'make clean' should leave the git repo in a clean state - so thatgit status
looks nice -
/usr/lib64
is the common location on 64 bit architectures - not on all, yes - but that's why the code tries to detect the situation -
$ARCH
is unused and can go - I believe it was used at some point for this lib64 decision
Thanks for your response! I'll remove the .gitignore
commit.
Just a heads-up: I haven't forgotten...