James Wetzel

Question - Filter rules & intended behavior

1

@vsoch - We came across a possible issue today with how filter rules are applied. In the sample dicom recipe, there are many filter rules defined such as below: [deid.dicom...

Refactor Unit Tests to utilize separate data store for sample images

5

Created this issue to continue discussion started on PR #166: > > With this proposed new issue, I believe that I have an opportunity to build out our test image...

Optimize replacement functionality

4

As discussed starting in [PR #112 (comment)](https://github.com/pydicom/deid/pull/112#issuecomment-594922571), optimize the processing of recipe actions to more efficiently perform defined actions. >I think we would want to parse an entire recipe first,...

Minimum Required Versions - Python >=3.7; Numpy >= 1.20

6

Hey @vsoch... I've been stale for a bit and have let my application lag at 0.2.28. Looking to update now and came across this: With the implementation of version 0.2.34...

When adding a filter rule which targeted a non-string field (DICOM VR - DS) the empty() function in filter.py throws an exception - "'DSfloat' object has no attribute 'value'". **Filter...