Wesley Wigham

Results 190 comments of Wesley Wigham

I agree that they should definitely behave the same - I image we probably need to pass forward the settings used for `primaryLookup` to `secondaryLookup`. (Which means we shouldn't respect...

Yeah, the important note was consistency in resolution between the two scopes - it's certainly more likely useful to always follow exports/other node style resolution rules for triple slash refs....

I'm thinking we should probably have triple-slash refs always use, eg, `nodenext` rules, this way refs work across DT regardless of the consuming package's tsconfig settings/if they are inside a...

Riiiight, I changed it from always-cjs to option-dependent when I added the mode flags... It should probably be changed to always-latest-node (which I mentioned as an option in that code...

Yeah, I think the mode override is meaningful for pulling in augmenting modules only accessible under import/require conditions, and the conditions should probably be the same `node, types, import ||...

I don't think the condition TS uses should depend on the resolution mode of the project - it'd make using the same declaration file in a minimal, node, and node16...

> The only other thing is to remove !!! emitDecoratorMetadata from program.go where we would have emitted an error on this option. AFAIK that's already gone, replaced with the error...

Ref #31384 which previously experimented with instrumenting diagnostic message construction to allow expandable spans like this.

PRs welcomed. You can find more information about contributing lib.d.ts fixes at https://github.com/Microsoft/TypeScript/blob/master/CONTRIBUTING.md#contributing-libdts-fixes.

@DanielRosenwasser you have a preference here?