Wesley Wigham comments

Results 190 comments of


                                            Wesley Wigham

Enable JS emit for noCheck and noCheck for transpileModule

@typescript-bot perf test this faster

Enable JS emit for noCheck and noCheck for transpileModule

@typescript-bot perf test this faster

Enable JS emit for noCheck and noCheck for transpileModule

@typescript-bot perf test this faster

Enable JS emit for noCheck and noCheck for transpileModule

I mentioned it in our meeting, but the only things not `noCheck`-flagged (aside from change the format of the API function from "get flags" to "has flag") at this point...

Isolated declarations uses type information when emitting computed object keys

FWIW, I don't think computed property names are compatible with `isolatedDeclarations` _at a fundamental level_ - wherever we land on the fix is going to be a compromise. Computed names...

Isolated declarations uses type information when emitting computed object keys

> There is no semantic issue here as far as I can tell, it's just something that is needed to achieve token level equality of the output. ish? The ID...

Isolated declarations uses type information when emitting computed object keys

These are all errors for now, but as we allow some of these forms as special cases, we do want to think about possibly aligning the emit output where possible,...

Improve reuse of nodes in signatures with type mapping

> On a related node. Why is renaming of shadowed parameters needed in this case? It's a bit more pessimistic than it strictly has to be sometimes, but the renaming...

Isolated declarations does not handle object getters and setters with different types

Hm. We didn't allow get/set in types for a looong time, and only added it to support differing getter/setter type pairs - and to avoid accidentally breaking backcompat for people,...

Skip typechecking for files with no check in them even with dts emit

> Does this need to wait for https://github.com/microsoft/TypeScript/pull/58364 given the ts-nocheck files may be emitting js? Either that or, like the other PR, only enabled when only `.d.ts` emit is...