Wesley Wigham

Results 190 comments of Wesley Wigham

Yeah, just remember the condition in `calculateNodeCheckFlagWorker` in `checker.ts` and `emitJsFileOrBundle` in `emitter.ts` needs to swap from just `compilerOptions.noCheck` to something that can handle this, too. (probably just the `skipTypeChecking`...

It doesn't really have anything to do with `npm link` - it's just that we don't see the `Joi` types reexported in `@privateprefix/lib` as an autogeneratable way to reference `joi`'s...

Our fix for this relies on `package.json` files within the compilation folder to discover available dependencies not explicitly included via imports in the project. To avoid crawling the whole directory...

Personally, I'd sooner like to see a `tsconfig.js` or `tsconfig.ts` affordance (similar to a webpack config) to generally leverage JS syntax for complex configuration merging rather than introduce special-snowflake "syntax"...

"Do not over-complicate the implementation with abstractions where a little copying will suffice" - Unattributed programming koan

Sorry if I came off a bit sarcastic (I suppose quotes around things in text imply sarcastic airquotes). I probably should have used italics to imply emphasis and emphaticness rather...

I, personally, would prefer a code file. @mhegazy disagrees. :) As I said, strong opinions.

> We want to report an error when creating a declaration for a type correct? Truncations already report a truncation error (via `reportTruncationError`) which the caller may/may not ignore -...

> I actually prefer to have the same behavior when NoTruncation is happening. Yeah, I generally do, too, that's why usually it all goes through the `createElidedInformationPlaceholder` helper usually -...

@ericanderson I actually started work on this today, sorry 😉