Wenyong Huang

Results 286 comments of Wenyong Huang
trafficstars

> > > @eloparco just my suggestion: maybe we can add two APIs, one is for WAMR api and is added in wasm_export.h, the other is for wasm-c-api and is...

> > Or how about providing wasm_module_is_underlying_binary_freeable instead of wasm_module_is_underlying_binary_cloned for wasm-c-api, and wasm_runtime_is_underlying_binary_freeable for wasm/aot loader? > > Do we need two separate APIs? One (i.e. `wasm_runtime_is_underlying_binary_freeable`, that checks...

> > while, in classic interpreter mode, after instantiation. > > i believe you can't free the buffer for classic interpreter. Agree, how about we merge this PR first and...

> > > > while, in classic interpreter mode, after instantiation. > > > > > > > > > i believe you can't free the buffer for classic interpreter....

@victoryang00 I only read several files of this PR and added some comments, and will look into more files in the future. BTW, I merged main into dev/checkpoint_and_restore (#3511), could...

> @xujuntwt95329 @yamt I'm trying to make `wamrc` compatible with different linux distributions like https://github.com/WebAssembly/wasi-sdk/releases. > > I thinks it's useful since we also provide prebuilt binary for wamrc. @no1wudi...

> btw, i wonder why dwarf_extractor.cpp uses the LLDB API, rather than, say, llvm/DebugInfo/DWARF/ api. @wenyongh do you remember? The source debugger feature was implemented by Ant group long time...

@nchamzn thanks for the PR to fix the issue, it is a good catch! I think we had better fix it by changing the aot compiler since in wasm memory64...

> Hi, thanks for looking - yes your suggestion looks good to me Welcome, I submitted PR #3378 to fix it with more comments added. Could you help check again?...

Close this PR since the issue was fixed with https://github.com/bytecodealliance/wasm-micro-runtime/pull/3378.