Wenyong Huang

Results 286 comments of Wenyong Huang
trafficstars

> > How about letting the developer pass a read stream callback to read n bytes from the wasm/aot file, somewhat like > > ```c > > typedef uint32 (*read_file_callback_t)(char...

Since https://github.com/bytecodealliance/wasm-micro-runtime/pull/3389 was merged instead, close this PR.

@loganek the macos CI failure should have been fixed with PR https://github.com/bytecodealliance/wasm-micro-runtime/pull/3366, please rebase your code to run again. Thanks.

> @wenyongh / @TianlongLiang I think the code is ready for review, I'd appreciate your feedback. @loganek thanks for the quick update. I just read the code quickly and added...

> > it's rather important to fail when it's expected to fail because, in case of aot, it's wamrc's resposibility to validate the module. > > I agree it's important,...

@loganek the PR LGTM except one issue left (change `(uint32)ptr` to `ptr` when calling execute_free_function), could you help address it and resolve the conflicting file? I think we can merge...

> @wenyongh I've addressed all the comments, thanks a lot for the review. > > Unless there are any other comments, the PR is ready for merge. Great work! I...

> not very sure about it. the binary content(in wasm_module_t) will be used during execution. It's on purpose to release the binary when destroying store. I think we can have...

> my impression is that this requires users too much implementation knowledge. > > how about providing an api to query if it's safe to free the buffer? > >...

> > how about providing an api to query if it's safe to free the buffer? > > What would the API do? Just return `is_binary_cloned` from `wasm_module_ex_t` in case...