Wenyong Huang

Welcome. And let's close this issue as it is fixed.

Glad to know that WAMR is tested in nearly 1million devices, it is cool!

I also think it was omitted intentionally, per my understanding, this PR makes the log look ugly and not easy to read, and now only LOG_FATAL and LOG_DEBUG dump the...

> * Only retry on EAGAIN or EINTR. > * On EINTR, don't count it against the retry budget. EINTR can happen in bursts. > * Log the errno on...

> honestly speaking, i don't understand why we bother to retry on mmap failure here at all. @wenyongh do you remember the reason? In my memory, we retry 5 times...

> > > honestly speaking, i don't understand why we bother to retry on mmap failure here at all. @wenyongh do you remember the reason? > > > > >...

> > > > > honestly speaking, i don't understand why we bother to retry on mmap failure here at all. @wenyongh do you remember the reason? > > >...

Yes, thanks for the feedback, I am not so sure whether the retrying will help a lot but I think we had better keep it, since it doesn't hurt much...

> About `WASMImportInst`: > > ~- Include other types of instances in the union, such as function, global, table, and tag.~ > > * The name `WASMImportInst` might need to...

BTW, I think the PR is to allow the developer to create the import memory instance by calling wasm_runtime_memory_create, then pass it with WASMImportInst array to wasm_runtime_instantiate, and then during...