Wei Zhou

Results 507 comments of Wei Zhou

@dseralathan this should be improved by #7911 can you test it ? you can run UI locally following https://github.com/apache/cloudstack/tree/main/ui#development

@DaanHoogland @rohityadavcloud how about this ?

> This code looks good to me @weizhouapache . I've been looking to see if we can guarantee what @rohityadavcloud states, as it makes sense. However, whether or not, that...

same result of the health check PR https://github.com/apache/cloudstack/pull/7344#issuecomment-1922893919 ![image](https://github.com/apache/cloudstack/assets/57355700/706f9fa0-0369-43c5-8e14-365a08a04b42)

closing this cc @DaanHoogland

did a quick testing, it looks ok the API command is ` 2024-04-26T08:20:25,740 DEBUG [c.c.a.ApiServlet] (qtp1375394559-21:[ctx-8dc8b523]) (logid:10e8a469) ===START=== 10.0.53.169 -- GET apiKey=FbdMHXgGot3JuiEmoldLwOo3ZWh4fGjSDTsLz5qXDZn05Q7CSh4ZXSFVJfNYUwWct5YBwHlLZKFVLR-NFKnLkw&command=listVirtualMachines&details=min%2Cnics&listall=true&response=json&signature=K3US18HTxZvG2pJ29nnP8N3PYRg%3D` the parameter ` (details=min%2Cnics)` is set as expected

> Did some manual testing. After this change, I have verified that the service created has external IP equal to hostname set in `service.beta.kubernetes.io/cloudstack-load-balancer-hostname`. And the same hostname is also...

this could be implemented via annotation, for example `service.beta.kubernetes.io/cloudstack-load-balancer-external-ip`