cloudstack icon indicating copy to clipboard operation
cloudstack copied to clipboard

Published 20 hours ago • verified publisher icon apache

kvm: support Rocky/RHEL/OL/Alma in the same cluster

Open weizhouapache opened this issue 1 year ago • 19 comments

Description

This PR fixes #8604

Types of changes

  • [ ] Breaking change (fix or feature that would cause existing functionality to change)
  • [ ] New feature (non-breaking change which adds functionality)
  • [x] Bug fix (non-breaking change which fixes an issue)
  • [ ] Enhancement (improves an existing feature and functionality)
  • [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
  • [ ] build/CI

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • [ ] Major
  • [ ] Minor

Bug Severity

  • [ ] BLOCKER
  • [ ] Critical
  • [ ] Major
  • [ ] Minor
  • [ ] Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

weizhouapache avatar Feb 12 '24 12:02 weizhouapache

@DaanHoogland @rohityadavcloud how about this ?

weizhouapache avatar Feb 12 '24 12:02 weizhouapache

@blueorangutan package

weizhouapache avatar Feb 12 '24 12:02 weizhouapache

@weizhouapache a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan avatar Feb 12 '24 12:02 blueorangutan

Codecov Report

Attention: Patch coverage is 75.00000% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 13.16%. Comparing base (672206c) to head (865c356). Report is 11 commits behind head on 4.18.

Files Patch % Lines
...rvisor/kvm/discoverer/LibvirtServerDiscoverer.java 75.00% 1 Missing and 1 partial :warning:
Additional details and impacted files 
@@            Coverage Diff            @@
##               4.18    #8641   +/-   ##
=========================================
  Coverage     13.16%   13.16%           
- Complexity     9200     9205    +5     
=========================================
  Files          2724     2724           
  Lines        258109   258116    +7     
  Branches      40228    40229    +1     
=========================================
+ Hits          33971    33986   +15     
+ Misses       219835   219823   -12     
- Partials       4303     4307    +4

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Feb 12 '24 13:02 codecov[bot]

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 8630

blueorangutan avatar Feb 12 '24 13:02 blueorangutan

One remark - we shouldn't allow mixing different major versions of any of these EL distros though. (so OL8 with Alma8 is okay, but not OL7 with Alma8)

rohityadavcloud avatar Feb 13 '24 05:02 rohityadavcloud

This code looks good to me @weizhouapache . I've been looking to see if we can guarantee what @rohityadavcloud states, as it makes sense. However, whether or not, that part of the logic doesn't change here, CLGTM. (and unit tests added!)

agree @rohityadavcloud @DaanHoogland

Currently it is supported to put different version of same OS distribution in the same cluster, for example ol8 and ol9, rocky8 and rocky9. It might be useful for users to upgrade the OSes. Normally the vm migration from older QEMU (e.g in rocky8) to newer QEMU (e.g. in rocky9) should work.

weizhouapache avatar Feb 13 '24 09:02 weizhouapache

@blueorangutan package

rohityadavcloud avatar Feb 16 '24 05:02 rohityadavcloud

@rohityadavcloud a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan avatar Feb 16 '24 05:02 blueorangutan

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 8679

blueorangutan avatar Feb 16 '24 07:02 blueorangutan

@blueorangutan test

DaanHoogland avatar Feb 16 '24 13:02 DaanHoogland

@DaanHoogland a [SL] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

blueorangutan avatar Feb 16 '24 13:02 blueorangutan

[SF] Trillian test result (tid-9258) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 42168 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8641-t9258-kvm-centos7.zip Smoke tests completed. 110 look OK, 0 have errors, 0 did not run Only failed and skipped tests results shown below:

Test Result Time (s) Test File

blueorangutan avatar Feb 17 '24 01:02 blueorangutan

@blueorangutan package

weizhouapache avatar Apr 24 '24 07:04 weizhouapache

@weizhouapache a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan avatar Apr 24 '24 07:04 blueorangutan

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9388

blueorangutan avatar Apr 24 '24 08:04 blueorangutan

@blueorangutan test

rohityadavcloud avatar Apr 30 '24 12:04 rohityadavcloud

@rohityadavcloud a [SL] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

blueorangutan avatar Apr 30 '24 12:04 blueorangutan

[SF] Trillian test result (tid-10098) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 46380 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8641-t10098-kvm-centos7.zip Smoke tests completed. 110 look OK, 0 have errors, 0 did not run Only failed and skipped tests results shown below:

Test Result Time (s) Test File

blueorangutan avatar May 01 '24 02:05 blueorangutan