Bruce Weirdan
Bruce Weirdan
> This all makes sense from Psalm's point of view. I can't see an easy way to fix it except to revert that part of https://github.com/vimeo/psalm/pull/10502 and go back to...
> Same here with non-stub : psalm.dev/r/6e1df08edd This doesn't fail anymore, but the original issue still reproduced as described.
Looks like I have deleted reproducer repo.
Can you provide several examples that you think should be flagged by Psalm? I _think_ I disagree with you, but would like to have some concrete examples to discuss. With...
`/** @var */` comments don't do anything in PHP either (neither do `@param` or `@return` docblocks), yet we still use them. How's `assert()`, which at least runs in dev/test environments,...
> which can be caught in the caller and handled Sounds like a misuse of assertions to me. As a rule of thumb assertion errors should _never_ be caught (unless...
Actually Psalm knows nothing about `php_user_filter` properties: ```console $ rg -i 'php_user_filter' dictionaries/CallMap.php 10157:'php_user_filter::filter' => ['int', 'in'=>'resource', 'out'=>'resource', '&rw_consumed'=>'int', 'closing'=>'bool'], 10158:'php_user_filter::onClose' => ['void'], 10159:'php_user_filter::onCreate' => ['bool'], dictionaries/CallMap_historical.php 14350: 'php_user_filter::filter' =>...
We now have it in our property map, but it doesn't seem to fix the issue. https://github.com/vimeo/psalm/blob/ceaea625f30289850c8a9274b9c79e21fa848dea/dictionaries/PropertyMap.php#L370-L374
The original issue with stubs is fixed, but we still need to find a way to validate them.
I've rebased it onto master as that's what psalm.dev uses.