Bruce Weirdan

Results 291 comments of Bruce Weirdan

Constructors generally don't have to be compatible. However we should report name mismatches if the constructor is declared consistent by using `@psalm-consistent-constructor`: https://psalm.dev/r/80275d44f3

No, it should be like the following: * when neither of `@psalm-consistent-constructor` / `@no-named-arguments` are present, no consistency (neither names nor types) is enforced * when `@psalm-consistent-constructor` is present without...

@boesing would you mind providing more info here? From the backtrace it looks like it crashed while reading a docblock for a property on a class that had type aliases,...

What's the last few lines starting with Parsing|Scanning before the crash?

That's consistent with the backtrace, thanks. Can you also check if replacing references to constants with their values here: https://github.com/Seldaek/monolog/blob/437cb3628f4cf6042cc10ae97fc2b8472e48ca1f/src/Monolog/Logger.php#L30 helps with the crash? Constants and typedefs are double fun...

The error is valid and should be fixed in PHP. Meanwhile, we should probably annotate `ArrayObject::offset*` methods as `@no-named-arguments`.

Psalm does not complain if you name the argument `$offset`: https://psalm.dev/r/ad9554f91a

To me, it looks way more complex than https://psalm.dev/r/75732c0bf7

Ah, I see. I would probably reject such a PR to Psalm. Alias handling in Psalm has its issues, and so do generics. Combining them sounds like a maintenance pain...

189 new errors reported in PHPUnit look quite worrying: https://app.circleci.com/pipelines/github/vimeo/psalm/13214/workflows/7c12912e-4b6a-4e48-9ba6-06a9d0015c09/jobs/43049