Bruce Weirdan

Results 291 comments of Bruce Weirdan

Not on lines 15/16 (those are **not** properties), but yes, `PropertyNotSetInConstructor` should be reported on the child class, similar to what we have for traditional properties: https://psalm.dev/r/8b9ddbf888

It appears Psalm reflects the runtime function definition when it can't find the requested function in callmap: ![image](https://user-images.githubusercontent.com/57403/142190010-950ff997-10a3-422b-981a-f97b3b53cced.png)

We have most of that data in callmaps (added and removed functions). If we're going to add deprecations for internal functions, it would make sense to have them there as...

The fix seems to be rather simple: https://psalm.dev/r/872aced924

@theodorejb I've been meaning to play with it locally, but haven't found the time yet. One thing that caught my eye is the type change for `$protected_var_ids` - perhaps there's...

@ohader #10350 is about intersections, and there seems to be nothing intersection-related in the stack trace here.

This works: https://psalm.dev/r/235b00ed02

IMHO, preconditions (#7169) would be a better way to address it.

Looks like there are some discrepancies in the callmap files. You may want to consult https://psalm.dev/docs/contributing/editing_callmaps/