Weihang Lo

Results 766 comments of Weihang Lo

Originally posted at . Here is another performance benchmark that focuses on cargo part. * Clone https://github.com/awslabs/aws-sdk-rust/commit/505dab66bf0801ca743212678d47d6490d2beba9 and `cargo check -p aws-sdk-ec2` (with pre-filled cache) * `rg 'checksum:blake3' target/debug/deps |...

Originally posted by @Xaeroxe at . Do the slower benchmarks appear to be I/O bound or CPU bound? If they are CPU bound, are all the cores saturated? I knew...

Originally posted by @epage at . > rg 'checksum:blake3' target/debug/deps | wc -l shows 8313 matches. It means rustc roughly computes blake3 checksum 8313 times. Should we avoid passing this...

@epage My impression is that rustc already computes file checksums, just with a different algorithm. The performance might be less interesting. After some discussions with @Muscraft, I can think of...

> Originally posted by [@Xaeroxe](https://github.com/Xaeroxe) at [#14136 (comment)](https://github.com/rust-lang/cargo/issues/14136#issuecomment-2430959657). > > Do the slower benchmarks appear to be I/O bound or CPU bound? If they are CPU bound, are all the...

Some more benchmark results with a permutation of `-Zchecksum-freshness` * `-Zbinary-dep-depinfo`, using the same script from : | Command | Mean [ms] | Min [ms] | Max [ms] | Relative...

> I am curious how often "time to prove build is fresh" is relevant to cargo's user satisfaction. Are users more likely to be upset about an incorrect freshness check,...

> and all my mtimes change with each run, so my valid cache contents are never used. The current implementation probably doesn't really help if your package have build scripts...

Thanks for filing this report, and sorry for the inconvenience. The function [`check_repo_state()`] is how Cargo checks VCS (Git) status to determine whether the repo is dirty. Roughly it compares...

#13592 is now merged. We have file listing support in gitoxide. I wonder if that is a step toward fixing this with gitoxide cc @Byron