Weihang Lo

Results 766 comments of Weihang Lo

`cargo-clippy` is exactly implemented as a custom subcommand, so this might be considered as a duplicate of . The reason environment variables work is that clippy later calls `cargo check`,...

There was a change (https://github.com/rust-lang/cargo/commit/e08848c974c1ab289d6240da113141d999b0639f) in #11407 giving richer information. It was backed out because the new display requires more design discussions than others. ![](https://rust-lang.zulipchat.com/user_uploads/4715/ZkL5rQVIejytE2kLgXvvLSwn/image.png) I don't mind adding them...

> Indeed, after switching to `docsrs` everything is fine. I found that it's explicitely included [here](https://github.com/rust-lang/cargo/blob/9b4a50183f574d64e57976e58ce74a638a9cc621/src/cargo/core/compiler/mod.rs#L1351) because that's what docs.rs uses internally, however I couldn't find it in any documentation,...

@bors r+ Thanks! (To me I might also make git commit messages clearer. You can see how people did it in this repo. Let's don't bother on this at this...

Does the single colon version work for you? (`cargo:rustc-check-cfg` specifically).

They are all good suggestions! @Urgau any opinion on this? Should we mention only single-colon syntax everywhere to avoid compatibility hazard?

> Maybe it could be mentioned in the MSRV error, since that's a case where you know for a fact that it's relevant to the user? Ie, an error that...

Thanks for the report. Yes, that's #12783, which fixes the behavior to match the documentation. See . This is considered as a bugfix for the implementation. I've opened to include...

Here is a [prior discussion](https://rust-lang.zulipchat.com/#narrow/stream/246057-t-cargo/topic/cargo.20metadata.20change.20in.20targets.2Ename.20field) of it. And I totally understand that. I'll check if we can make JSON message documentation a bit clearer. Thank you.