cargo icon indicating copy to clipboard operation
cargo copied to clipboard

Old syntax suggestion

Open torhovland opened this issue 1 year ago • 2 comments

Fixes #13868.

The build error in the issue will now include a suggestion:

   Compiling zerocopy v0.8.0-alpha.9
error: the `cargo::` syntax for build script output instructions was added in Rust 1.77.0, but the minimum supported Rust version of `zerocopy v0.8.0-alpha.9` is 1.56.0.
Consider using the old `cargo:` syntax in front of `rustc-check-cfg=`.
See https://doc.rust-lang.org/cargo/reference/build-scripts.html#outputs-of-the-build-script for more information about build script outputs.

The suggestion is only included for reserved prefixes.

A test has been added.

torhovland avatar May 07 '24 08:05 torhovland

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @weihanglo (or someone else) some time within the next two weeks.

Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (S-waiting-on-review and S-waiting-on-author) stays updated, invoking these commands when appropriate:

  • @rustbot author: the review is finished, PR author should check the comments and take action accordingly
  • @rustbot review: the author is ready for a review, this PR will be queued again in the reviewer's queue

rustbot avatar May 07 '24 08:05 rustbot

@rustbot review

torhovland avatar May 07 '24 10:05 torhovland

OK, I squashed a couple commits. Hope that's better.

torhovland avatar May 08 '24 21:05 torhovland

@bors r+

Thanks!

(To me I might also make git commit messages clearer. You can see how people did it in this repo. Let's don't bother on this at this moment and move on 👍🏾)

weihanglo avatar May 08 '24 21:05 weihanglo

:pushpin: Commit 3ea3638c1b2718d01dab8fd6d115b58d40134032 has been approved by weihanglo

It is now in the queue for this repository.

bors avatar May 08 '24 21:05 bors

:hourglass: Testing commit 3ea3638c1b2718d01dab8fd6d115b58d40134032 with merge 1fec08999177fb768e468653dd05ff8bf8e250b9...

bors avatar May 08 '24 21:05 bors

:sunny: Test successful - checks-actions Approved by: weihanglo Pushing 1fec08999177fb768e468653dd05ff8bf8e250b9 to master...

bors avatar May 08 '24 21:05 bors