Simon Warta

Results 423 comments of Simon Warta

The deprecation note is a good idea indeed. It's here now: https://www.npmjs.com/package/@cosmjs/crypto/v/0.33.1. > it needs an advisory reported in https://github.com/cosmos/cosmjs/security that'll show up whenever people run npm audit True, but...

This is something declared in cosmjs-types (or even Cosmos SDK) which we pass on to the user. So I think it is fair to annotate them with ignores for all...

Nice! I like no-unsafe-member-access and no-unsafe-enum-comparison

Is bech32m used for Cosmos chains? Who does this? Is this possible to do with the Cosmos SDK or a major fork? Asking genuinely curious here as I was wondering...

Interesting. I also just found https://github.com/hyperweb-io/telescope/issues/642. Decimal was never written for the Cosmos SDK type `github.com/cosmos/cosmos-sdk/types.Dec`. It was meant to make writong dapps with balances easier and avoid add the...

After #1916 the Decimal type is pretty much fully migrated from string to bigint. This should make it easy to add extra tests and remove the restriction to non-negative values.

Could you review https://github.com/cosmos/cosmjs/pull/1930?

I think I'll do a ~0.32.x~, ~0.33.x~, 0.34.x and 0.35.x patch release which just includes the deprecation annotations. This increases the chances for users seeing the warning next time they...

I would consider this low priority. Cyclical dependencies inside of a package are not the most beautiful thing in the world but also not an issue at all. This is...

Heyhey, looks good overall. Could you update theis to latest main? The cli package was removed entirely in the meaintime