Simon Warta
Simon Warta
The last commit (the uncommitted dependency change) is not needed. See https://github.com/cosmos/cosmjs/issues/1922
Looks good overall, thank you. I will take care of linting and stuff to make CI happy tomorrow and then merge it
Okay but using isomorphic-ws for Node 20/22/24 support does no harm, right? The package looks incredibly simple and `require('ws')` is likely not going away any time soon.
Oh they do something: avoid typos in the type name string literal
What's the motivation for migrating away from Jasmine? Looks like a significant endeavor with unclear reasoning right now.
Ah, nice, thanks, understood. Sounds good.
I think we can just manually set the config file path on order to work around the ESM issue: https://github.com/cosmos/cosmjs/pull/1725 Not a solution for the entire ticket, but a step...
From the Karma deprecation note > For those outside Angular looking to migrate off Karma, both [Web Test Runner](https://modern-web.dev/docs/test-runner/overview/) and [`jasmine-browser-runner`](https://github.com/jasmine/jasmine-browser-runner) provide browser-based unit testing solutions which can be used...
Interesting, looks good at first glance > I'm guessing migrating to using real json validation like `zod` would be overkill. Yeah, agreed. Also I don't like external libraries in our...
The majority of CosmJS user do not use CosmJS for key storage, signing or signature verification in production. In fact I am not aware of any wallet or other project...