Webber Takken

Results 281 comments of Webber Takken

Could you provide much more context about what the changes are doing exactly and why they are needed? Also; Are these changes only needed in test-runner? Did you consider adding...

@Mannilie Thanks a bunch for the excellent write-up of the context. It is extremely valuable to us. It doesn't look like a huge amount of work to incorporate these changes,...

You are correct in your observation that we're not passing non-specific env variables into the container. You can use [customParameters](https://game.ci/docs/github/test-runner#customparameters) to pass any parameters into the image and read them...

Thanks for creating this issue. We agree this would be nice to have as well. If I remember correctly, this has been requested before but no pull request was ever...

Personally I feel we should use great defaults instead of creating another configuration option here. We could do an automated check for the amount of tests and determine how to...

Hi @antja0 and thank you for your feature request. We are open to improve test runner to account for cases like this. I think your suggested solution might be a...

> By the way, I noticed the pre-commit hook wasn't working > ... > I updated the file to be executable and the hook started working for me again, so...

> I think I would need to ask the maintainers their preference here, since there's two options We mostly prefer small iterations where possible so if this is a chunk...

> BTW, I've been pretty busy the past couple weeks, and the rest of this week - not sure when I'll get around to addressing the feedback. No rush :)...

Completely understandable if your priorities are shifting. To me the feature doesn't need to be 100% done as long as it covers at least the flow you were going for...