Ryan Weaver

Results 336 comments of Ryan Weaver

Interesting... I think I saw that library - https://github.com/shepherdwind/css-hot-loader - before, but it looked really low quality (even if it worked). But a lot of work has been done over...

@tburschka Hmm, we just need to make sure that my hack was in fact the right hack (and that it's not the problem). What happens if you `console.log(config.module.rules[1].use)`? I want...

Awesome! And this works really well? Can you tell me more about why the `module.hot.accept()` is needed?

It's on the TODO list :). HMR has some complexities because we always dump `.css` files, even in dev, instead of using the `style-loader` trick. That gives us consistency across...

Yea, that's pretty valid... basically HMR doesn't work with the css-loader, but works fine (and is intended for) the normal style-loader. We chose to use the css-loader consistently, because I...

We should document this... and maybe also make `disableCssExtraction()` have a boolean first argument so you can use `Encore.disableCssExtraction(Encore.isDevServer)`

That's an interesting idea! I am open to it if someone wants to submit a pull request :).

Hey! does supporting version 10 cause some sort of error with the latest beta? You mentioned it did - what is it? and, yes, in general, I am a fan...

@Kocal i actually have it on my list to simply remove appveyor - I purposely didn’t update its config to fix the node version problem because we test on windows...