webpack-encore icon indicating copy to clipboard operation
webpack-encore copied to clipboard

New webpack-dev-server beta upgrades minimal node version

Open ghost opened this issue 3 years ago • 6 comments

Since webpack-dev-server.beta.3 is release (25days ago) the minimal node version supported by this module is ">= 12.13.0"

Can you update the package.json to remove the version ^10.19.0 that is still supported by webpack-encore, to avoid installation that will failed because of this dependance.

Or maybe if it is not necessary for the main usage of webpack-encore, let the users install webpack-dev-server if they want to use webpack-encore dev-server (like the sass-loader is not included but a warning is showed when it is necessary)? To let people (like me) use webpack-encore with old node version as much as we can ? 😅

ghost avatar May 31 '21 16:05 ghost

Hey!

does supporting version 10 cause some sort of error with the latest beta? You mentioned it did - what is it?

and, yes, in general, I am a fan of making some libraries - like webpack-dev-server - something or users install directly

weaverryan avatar May 31 '21 16:05 weaverryan

@weaverryan I think you can take a look to https://ci.appveyor.com/project/weaverryan/webpack-encore/builds/39399483/job/o2t29it4dfon5lmg

Kocal avatar May 31 '21 17:05 Kocal

@Kocal i actually have it on my list to simply remove appveyor - I purposely didn’t update its config to fix the node version problem because we test on windows now on GH actions :)

weaverryan avatar May 31 '21 23:05 weaverryan

Oh, and I think you were actually trying to point out the error 🤦

you get that error if you’re using node 10. But if we removed node 10 support from package.json, that would just give you a different (or maybe the same ?) error when using node 10, right?

weaverryan avatar May 31 '21 23:05 weaverryan

Yes I have the error that @Kocal showed if I try to install webpack-encore using node 10.

If we remove node 10 from package.json, when we install webpack-encore, it will directly say that webpack-encore is not compatible with node 10 instead of having this strange error.

But if we remove webpack-dev-server from dependencies, webpack-encore is still compatible with node 10, and people who use webpack-encore dev-server will have to install this package. If they use node 10 they will get an error saying webpack-dev-server needs node 12.

What do you think about the 2nd solution ?

Dev0Pher avatar Jun 01 '21 06:06 Dev0Pher

@weaverryan Do you have an update for this ?

Dev0Pher avatar Jun 16 '21 12:06 Dev0Pher