Ryan Weaver

Results 336 comments of Ryan Weaver

Thanks for the details! Try this: ```js var Encore = require('@symfony/webpack-encore'); Encore .setOutputPath('./build/') .setPublicPath('/my-path/themes/default/build') .setManifestKeyPrefix('themes/default/build') // ... everything else the same ; // export the final configuration module.exports = Encore.getWebpackConfig();...

Hmm, interesting... I wonder if we could update Encore to use relative paths internally. I mean, logically, it makes sense to output a CSS file with a relative path to...

A PR would be cool :). I don't know yet if we should do this approach, or something more "generic" (e.g. a "hook" to edit the config for any rule),...

> The solution is to define optional peer dependencies Do "optional peer dependencies" exist? Is that a thing you can actually define?

Hey @drazik! What version of Encore are you using? Since 0.29.0 - https://github.com/symfony/webpack-encore/commit/9f18ba946c83601badab4255ae4861f40c340852#diff-2c340636121f50f8e63cb04aabce0a24aa3e64bba5cb8670f7f9bf56788fd4b5 - I believe that we don't set `modules: true/false`. Well, we DO set it to an object...

@thewalkingcoder so this only happens with 1.0 of Encore? `0.33.0` works fine? Can you show - by clicking on one of the errors in the console - exactly which syntax...

Hi @thewalkingcoder! Thanks again for the super detailed report. All the files you attached to your previous message (e.g. `app.js.txt` and `vendor-d8d333.js.txt`), these are your final "built" files, correct? If...

What does your raw JavaScript look like? And do you have this config https://github.com/symfony/recipes/blob/d5faacab431e71baff3798f09dabfc89ea5f90cb/symfony/webpack-encore-bundle/1.0/webpack.config.js#L53-L56 ? `Symbol` is a feature that's not supported on IE11... I'm not sure if Babel is...

Ok, so I hunted this down a bit. The `Symbol` code that's in your final, built files is coming from Webpack's logger - https://github.com/webpack/webpack/blob/911ec1aa67011e25aa1449610f5b0b557edd5459/lib/logging/Logger.js#L34 I have no idea why Webpack's...