James Reeves comments

Results 890 comments of


                                            James Reeves

Bugfix: Make util/request-url handle empty query string

My reservation is that an absent query string and a blank query string are different things when parsing a URL. For instance, I'd expect `"https://example.com/?"` to have a query string...

Bugfix: Make util/request-url handle empty query string

Oh, yes please. I think that would be a good change to make regardless. I'll keep this PR open a little while longer while I consider it, though.

Bugfix: Make util/request-url handle empty query string

Yes, there's certainly a tension between behavior that's more consistent vs. behavior that's more practically useful. Typically more basic functions will lean toward consistency while more advanced functions aim for...

Update ring-jakarta-servlet dependency version and add web.xml for versions 6.0 and 6.1

Thanks for the PR. Can you ensure that the subject line of the commit messages is 50 characters or less, and the body of the commit wraps at 72 characters?

Update ring-jakarta-servlet dependency version and add web.xml for versions 6.0 and 6.1

Perfect. And just to confirm - have you tested this change? Does it work with Tomcat?

Pedestal generates multiple `Content-Type` values if given a header name that does not case-match `Content-Type`

> My impression is that the lack of specificity for response headers is an historical accident that'd be difficult to walk back now. It was deliberate, as there may be...

Spec Support for 103 Early Hints and other informational response types

Thanks for opening the discussion on this. To manage expectations, this may take a while to find its way into the spec, if at all. Spec changes are something that...

Spec support for connection close notification

This is a reasonable addition and I think can be accomplished via an additional protocol that can be applied to the body. For instance: ```clojure (defprotocol CloseableResponseBody (on-client-close [body response]))...

Issue with nested reitit routes in upcoming version

Thanks for the bug report! I'll investigate, but it might take me a couple of weeks to find time to do so.

Issue with nested reitit routes in upcoming version

I've released 0.12.8 that should fix this issue. Please can you confirm?