lein-ring icon indicating copy to clipboard operation
lein-ring copied to clipboard
verified publisher icon weavejester

Update ring-jakarta-servlet dependency version and add web.xml for versions 6.0 and 6.1

Open waynedyck opened this issue 4 months ago • 5 comments

This pull request also incorporates the updates in pull request #224 from @madoxas.

With the shift from javax.* to jakarta.* package names, the minimum supported Tomcat version is 10.1 at the moment and it uses servlet version 6.0. I also added the web.xml servlet definition for Tomcat version 11.

waynedyck avatar Aug 22 '25 17:08 waynedyck

Thanks for the PR. Can you ensure that the subject line of the commit messages is 50 characters or less, and the body of the commit wraps at 72 characters?

weavejester avatar Aug 22 '25 19:08 weavejester

Thanks for the PR. Can you ensure that the subject line of the commit messages is 50 characters or less, and the body of the commit wraps at 72 characters?

Done.

waynedyck avatar Aug 22 '25 20:08 waynedyck

Perfect. And just to confirm - have you tested this change? Does it work with Tomcat?

weavejester avatar Aug 22 '25 23:08 weavejester

Perfect. And just to confirm - have you tested this change? Does it work with Tomcat?

Yes. I just tested the changes again on an application with lein ring uberwar and was able to deploy the .war file and have it run on Tomcat 11.0.10 without issues.

The current version, [lein-ring "0.12.6"] still works on Tomcat 9.0.73 without the changes.

waynedyck avatar Aug 23 '25 00:08 waynedyck

@weavejester Do you require anything else from me at this point regarding the pull request?

waynedyck avatar Aug 27 '25 15:08 waynedyck