James Reeves

Results 828 comments of James Reeves

Apologies for the delay in looking at this. This seems a reasonable change. Can you remove all irrelevant changes (e.g. deps.edn), squash the commits down, and set the commit message...

Just coming back to this. A deps.edn file can be added in a separate PR, but is not required for this PR and so should be removed. I'll merge once...

This isn't intentional behavior in Ring; the `StreamableResponseBody` should be responsible for closing the response stream, as otherwise a response with a long `InputStream` as a body would not transmit....

I investigated this, and at least in the case of Ring, I believe I now understand why this occurs and why it *probably* isn't a bug: https://github.com/ring-clojure/ring/issues/491#issuecomment-1925040669

I found this issue again after reading [a comment](https://github.com/starfederation/datastar/issues/571#issuecomment-2631079612) that described differing behavior between Ring-Jetty and rj9a. In Ring, closing the output stream completes the response. I have a [proxy...

Thanks for the commit, and apologies for the delay in reviewing it. Can you add a simple test just to prevent any regressions in future. With regard to #13, I...

Then perhaps the rule is that functions with the collection as the first argument retain metadata, and otherwise it doesn't. Hence `update-vals` retaining metadata, and `mapv` not doing so.

Looks like this PR is still waiting on a test. Would you be able to write one @tomdl89, or do you not have time? If needs be, I can write...

Thanks! Could you squash the tests commit into the original? Then I'll merge it into master.