James Reeves

Results 830 comments of James Reeves

Thanks. Could you also slim down the commit message? There's no need to explain everything about the change. You can just provide a small explanation and a link to more...

Rather than adding tags everywhere, I think it might be better to understand why tagging the s3-client var doesn't work in the first place.

Also, which Clojure version are you using?

Apologies for taking a few days to reply to this. My plan regarding `copy-object` was to switch to a map of objects after four arguments, so something like: ``` clojure...

Could you fix the length of the commit messages? The first line of a git commit message is used as a brief summary, and should typically be kept under 70...

Thanks. I think that perhaps we could shorten "configuration" to "config" without losing any clarity, i.e. `get-bucket-website-config` and `update-bucket-website-config`.

Oh, also, I note that the keys for the new functions are camel-cased, rather than hyphenated. Could you change the keys to use the hyphenated form, e.g. `:routing-rules` rather than...

I wonder if we should prefer Cheshire over data.json. Thoughts?

What keys are allowed in `update-bucket-policy`? The docstring doesn't say.

Okay, that's reasonable. A link to the docs should be sufficient.