James Reeves

Results 833 comments of James Reeves

I feel the code could be a fair bit smaller than it is. There are functions like `margin` and `index-of` already in the codebase that I think would make the...

@PEZ, yes, the PR needs more work before it can be merged. I've detailed in the comments the things that need to be changed.

@tkachenko1503 See my previous comment and code review.

@lread `:align-args` simply denotes which arguments of a form should be aligned. So for instance in a `let` form: ```clojure (let [foo 1 y 2] (+ foo y)) ``` We...

Here's an example from Schema: ```clojure (s/defrecord StampedNames [date :- Long names :- [s/Str]]) ``` Notice that in this case, the pieces being aligned change as well.

What about if we there are N elements to a line, then we align each of the N elements into its own column? e.g. ```clojure [:one :two :three :four :five...

We can add an option to turn it off for maps, but my initial thought is that if you have a map that long, you probably want to write it...

Sorry, why would that matter? Even if the indentation is wrong, that doesn't affect how the forms are aligned, does it?

Ah, I see. I think that it should work independently, as in theory you could have: ```clojure { :one :two :three :four} ``` And have it aligned: ```clojure { :one...

I think that's a good idea; however, my goal with cljfmt wasn't to provide a canonical format, but to fix any formatting issues that were obviously wrong. Have you looked...