Walter Doekes

Results 279 comments of Walter Doekes

I can file a PR if you like. 8.1+ only then? Then I'll do `string|array` and remove the PHP_VERSION check.

Here's an alternate fix: https://github.com/wdoekes/gtkradiant-deb/blob/main/patches/radiant-fix-std-bool-std-byte.patch

Hi Garux, I have indeed seen that the numbers aid in debugging. Having some kind of pre-commit hook to remove numbers however is a pain. This would help when looking...

Also: > Committer also likely never had actually mapped, otherwise he would know, [..] But for newbies to map making, it can be advantageous to see exactly which changes in...

@ensiform : your memory serves you correct. GtkRadiant loads brushes and entities in reverse order, causing it to flip on every save. https://github.com/wdoekes/gtkradiant-deb/blob/main/patches/radiant-load-map-in-saved-order.patch

Here's that numbering "oneliner" in perl: ```perl #!/usr/bin/env perl sub pe{print "// entity ".$e++."\n";$b=0;}; sub pb{print "// brush ".$b++."\n"}; $d=0; for(){ /^{/ && $d eq 0 && pe; /^{/ &&...

@Garux: I'm sure you agree that even if the patch is not useful to you, it could still be included if it benefits others? > [...] extra dirt in the...

I'm sorry you feel that way. As for the sed-solution, the correct syntax would be: ``` sed -e '/^\/\//d' ``` ```console $ for x in //comment 1 2 //comment 3;...

You're talking about #108 I assume? Oh, I had not noticed that it did not work for new files. That's awkward. Apparently I have only tested it on existing maps......

Confirmed, Microsoft decided to behave differently indeed: https://docs.microsoft.com/en-us/cpp/c-runtime-library/reference/rename-wrename?view=msvc-170#remarks > The new name must not be the name of an existing file or directory. https://man7.org/linux/man-pages/man2/rename.2.html > If newpath already exists, it...