Walter Doekes

Results 279 comments of Walter Doekes

Well.. in that case perhaps those logs should be toned down to NOTICE level. (Or DEBUG, if there really are tons of them.)

![image](https://user-images.githubusercontent.com/1225014/84042115-f8ac6600-a9a4-11ea-9cf3-d2e82beea58b.png)

Note that PR #107 attempts to hide some errors and make them debug-level instead. Feel free to test and comment.

@bsdice If you try: `AT+CUSD=1,"AA182C3602",0` With 0 or 1 or 2 or 3, it should also work, right? I assume that `15` will mean UCS2 (+8bit +some other info..), so...

> This commit should not have happened imho in this form, much too large and complex for a single commit. Always split up such changes in multiple steps to make...

> I totally get what you are saying. But did you ask? Younger programmers imho just don't know that splitting changes into smallish chunks aids in debugging immensely. Would have...

Thanks for the updates. Okay. Calling ``` + static const char cmd21[] = "AT+CSCS=\"GSM\"\r"; ``` first in your case sounds good and portable. Switching to back and from UCS2 feels...

``` asterisk-chan-dongle$ git log -S AST_MODULE_SELF_SYM commit 9529a68056331e46fceca8a3480c5883d931e1f1 Author: Walter Doekes Date: Sun Sep 4 16:19:28 2016 +0200 Fix compile issues with Asterisk 14. Declare AST_MODULE_SELF_SYM=__internal_$(module_name)_self. ```

``` $ git log -S asterisk/version.h commit 9108a966aa146487815f639f653cd0401e2849c5 Author: Walter Doekes Date: Sat Sep 5 17:21:25 2015 +0200 Add Asterisk 11 support. Author: me, in August 2013. ``` ``` $...

I'm saying that: - you have a compilation problem with version.h - I fixed a problem with version.h in the commit which you can find using `git log -S version.h`...