watany comments

Results 64 comments of


                                            watany

wrong example in configmap help

I found it, so I'll think of a simple idea and try to PR

fix(config): Creating multiple rules from the same lambda

@corymhall Hi. I understand from the PR that the CDK team is busy and it pains me to say this, but may I ask when you expect to be able...

fix(config): Creating multiple rules from the same lambda

Addendum:. I have created a hash from FunctionName, AccountID, and Region to make the suffix unique. Therefore, the omitted parts in the test code have been modified to fix the...

fix(config): Creating multiple rules from the same lambda

@corymhall Excuse me for being busy, I tried to fix it with reference to the lambda implementation, but what do you think?

fix(config): Creating multiple rules from the same lambda

Thanks for confirming. I was satisfied with your comments and have incorporated all of them. I have imported them with the suggestion feature of Github and will add the test...

fix(config): Creating multiple rules from the same lambda

I am glad to have gained another knowledge.I was able to put the test independent of region,account. Thanks for sharing your tips.

fix(config): Creating multiple rules from the same lambda

@Naumel How did you fix the comment (typo) you received? I am sending you a reviewer once, but if you need to change it, I would appreciate it if you...

fix(config): Creating multiple rules from the same lambda

@corymhall Thank you for your answer. To be honest, it's hard for me to come up with test ideas right away. If you hesitate to implement a variable fixed ID...

fix(config): Creating multiple rules from the same lambda

Removed the conflict. please confirm.

fix(config): Creating multiple rules from the same lambda

I haven't changed the implementation since corymhall tried to merge. This time I only fixed the conflicting test code