watany

Results 64 comments of watany

@gracelu0 Thank you for the swift review. All tasks, including the integration test, have been completed. Could you please verify?

@gracelu0 Sorry for rushing you when you're busy, but could I ask you to review this?

@godwingrs22 Thanks for the review. Those are pertinent comments and have been corrected.

@godwingrs22 I understand the content, but this cannot be achieved with the current implementation. The lambda.FunctionUrl property does not include authType, which means, for example, the URL Auth Type of...

@godwingrs22 I assumed that I was being asked for a validation feature, so I submitted a pull request at https://github.com/aws/aws-cdk/pull/31590. However, if this is unnecessary at this point and can...

@rhermes62 @gracelu0 Thank you. I am happy to share that I was also able to confirm the Alias pattern. https://github.com/aws/aws-cdk/pull/31339/commits/8be1369ce8462835cdecf0c176d467ecc13a9e2f

@gracelu0 Could you please provide an update on the status of this review?

Once this is done, close it because the Conflict with the existing code is too large.

Please take a look at the following PR I'm working on for CDK! https://github.com/aws/aws-cdk/pull/31339. This enables CloudFront + OAC + Function URL integration. If this can be implemented smoothly, wouldn't...