Marcin Warpechowski

icon company Handsontable icon location Gdynia icon location Creator of Handsontable, previously at Starcounter.com

Results 202 comments of Marcin Warpechowski

Change the Demo to use a DIV, not an IFRAME

The problem with oversized headers reported in https://github.com/handsontable/handsontable/pull/9833#pullrequestreview-1084966930 and https://github.com/handsontable/handsontable/pull/9833#issuecomment-1226863565 is fixed in the commit ae435d72c080b49ff837d498e3d0bcaf2d3262d0. The reason was that Handsontable was initialized before the DOM was fully laid out.

Change the Demo to use a DIV, not an IFRAME

I just pushed changes that load the React demo in the React flavor of the docs.

Change the Demo to use a DIV, not an IFRAME

> @warpech There are quite a lot lint errors and possible styling improvements (lack of empty lines between variable definitions and the logic etc) that need to be addressed before...

Change the Demo to use a DIV, not an IFRAME

@budnix can you please do the re-review, because @jansiegel does not work tomorrow

Change the Demo to use a DIV, not an IFRAME

Thank you @aninde but I still want to make the DRY improvements @budnix pointed out.

Change the Demo to use a DIV, not an IFRAME

I'll try to finish this PR this week

Change the Demo to use a DIV, not an IFRAME

I solved the conflicts created by the fact that this PR was based on handsontable/handsontable#9441, which itself was squashed-merged to develop. 1. Merge ab2b08e240150e30abdcaf58c4ec8d4ab67993ec (the last commit from handsontable/handsontable#9441 before...

Delete removed core methods from definition file: `rowOffset`, `colOffset`

Reopening as this should be closed only after the release of 12.1.3

Missing support for `source` argument in `setSourceDataAtCell` if changes are an array

Reopening as this should be closed only after the release of 12.1.3

Docs: Two 404s on Custom-builds page , one on Introduction page

@krzysztofspilka discovered that the link `Switch to the React version of this documentation` on page https://dev.handsontable.com/docs/javascript-data-grid/ also redirects to a wrong URL (https://dev.handsontable.com/react-data-grid). @budnix pls make sure to cover that...