Marcin Warpechowski
Marcin Warpechowski
The main problem is that this repo has a little bit of an identity crisis. ### Is it called "Fast-JSON-Patch" or "JSON-Patch"? We tried to the name a while ago....
Cool! A nice rebus :) Can be written in unicode, too: {⚡±}
Agreed. Actually we addressed this problem before (there was a PR: https://github.com/Starcounter-Jack/JSON-Patch/pull/53), so that sounds like a regression. There is even a test for that: https://github.com/Starcounter-Jack/JSON-Patch/commit/b2435fa725a2a4efc7eb7b7059ddf5fa4c344771#diff-2f9a66403e6f581b7b3abaff2c80ca45R694. Maybe the test is...
The vendor neutral [JSON-Patch test suite](https://github.com/json-patch/json-patch-tests) uses both `.../` and `../-` to add elements at the end of the array. They seem to be equal choices. I guess that a...
I just checked with a plain TS project and it seems to work as expected with fast-json-patch `3.0.0-1`. I think that TypeScript works well with MJS as long as you...
Sorry, I forgot to push my final version of the files to https://github.com/warpech/fast-json-patch-typescript-demo Now I have pushed it and the wildcard import works OK: https://github.com/warpech/fast-json-patch-typescript-demo/blob/b2a668291ba0701ec3bfaed97823f815c125bd45/index.ts#L2
I think this issue might be closed, right @tomalec? OT is implemented outside of this repo and it works.
Regarding the `TODO` in the line https://github.com/Palindrom/JSONPatcherProxy/blob/c461b492a4fa2e2869ba99cbe0329db3846e93cd/src/jsonpatcherproxy.js#L280, do not miss the comment in https://github.com/Palindrom/JSONPatcherProxy/pull/39#discussion_r291162813
Thanks for the idea @alshakero and thanks @tomalec for the counter-idea :) I think that **sync** is worth trying in something that we can call `Palindrom 3.0.0-rc.1`. If we discover...
What's the status of this? Is JSONPatcherProxy still sync? Any problems with it so far?