Marcin Warpechowski

icon company Handsontable icon location Gdynia icon location Creator of Handsontable, previously at Starcounter.com

Results 202 comments of Marcin Warpechowski

Cells using a react renderer becomes blank when cell is validated

@bulaj does PR https://github.com/handsontable/handsontable/pull/9828 solve this problem?

Progress and Rating columns should be editable in the main demo

As part of this issue: 1. the data source should be changed from an array of arrays to an array of objects 2. the source code should be improved to...

Progress and Rating columns should be editable in the main demo

This should be done as 1 framework = 1 pull request, starting from React.

Fix an issue with dropdownMenu not being displayed on a nestedHeaders-enabled instance with all rows trimmed out.

Does it also fix #9930?

Internal: The `verify-bundles` freeze's helper script fails.

@jansiegel I think that about half of `verify-bundles` has the potential to be reused in https://github.com/handsontable/handsontable/issues/9879. If you agree, what lines would you recommend? Maybe this script can be changed...

Internal: The `verify-bundles` freeze's helper script fails.

That would also satisfy another conclusion from our [internal discussion](https://handsoncode.slack.com/archives/C4PV4S33Q/p1655884627801829) that the `verify-bundles` script should always run in the CI, not only before a release

Misaligned column headers in the main demo

AFAIK this is only reproducible in an `iframe`.

[11.0.0+] dropdownMenu open() method with filtering

This was solved in #9829 with a breaking API change. A new PR will be made to revert to the previous API

The BindRowsWithHeaders option is lacking some description

Another problem is, that in the current docs (12.1.0), the example shows the use of `bindRowsWithHeaders : 'strict'`, but it does not match the preceding text:

Change file extension of react wrapper js files to mjs/cjs for jest compatibility

Thank you @danyx23 for this report. > If you want I can try to create a minimal repo that shows the test issue with jest That would be more than...