Walter Simson

Results 96 comments of Walter Simson

It seems it has been done by some users on the [k-Wave forum](http://www.k-wave.org/forum/topic/successful-compilation-of-cuda-code-on-macos#post-7511).

@djps can you better describe what the current behavior is and what enhancement is needed?

Currently in `save_h5_file` all values are cast to float32 [here](https://github.com/waltsims/k-wave-python/blob/47eb6b4c3696c48a916a990db30585500b840195/kwave/kWaveSimulation_helper/save_to_disk_func.py#L479-L506). We can continue to look into this behavior and try to ensure that precision is taken into account.

This would need deprication warnings with planned deprication.

For context: https://stackoverflow.com/questions/30826224/how-to-get-complex64-output-from-numpy-fft

- [ ] We can move `kwave_array` to `kwave.array` to make it easier to find and then `tol_star` as a helper function in the `array` file

It might make sense to make the argument an enum to be able to type the options. Also this would prevent the int/string type mixing.

Hey Harish, welcome! I look forward to your PR. Best, Walter