k-wave-python icon indicating copy to clipboard operation
k-wave-python copied to clipboard
verified publisher icon waltsims

Refactor make_line in kwave.utils.mapgen

Open waltsims opened this issue 1 year ago • 6 comments

Refactor make_line. The function is too long and confusing and could be broken down into subfunctions and simplified.

waltsims avatar Jan 16 '24 01:01 waltsims

@waltsims Would you mind assigning this issue to me? I would appreciate the opportunity to work on it.

Harish-M-2003 avatar Jan 16 '24 13:01 Harish-M-2003

Hey Harish,

welcome! I look forward to your PR.

Best, Walter

waltsims avatar Jan 18 '24 18:01 waltsims

Hi @waltsims ,

Thank you for the warm welcome!

Best regards, Harish

Harish-M-2003 avatar Jan 19 '24 07:01 Harish-M-2003

Hey @Harish-M-2003, Checking in on this Issue. Do you think you would be able to close a PR by the deadline for the v0.3.3 milestone on April 3rd?

waltsims avatar Feb 28 '24 01:02 waltsims

Unfortunately, I regret to inform you that I am unable to continue with it at this time. I apologize for any inconvenience this may cause

Harish-M-2003 avatar Feb 28 '24 04:02 Harish-M-2003

No problem.

waltsims avatar Feb 28 '24 05:02 waltsims