Walter Simson

Thanks for the PR @gordon-n-stevenson !

Hi @faberno, Thanks for the PR! I appreciate you adding these small fixes. Please have a look at the failing tests before I review you PR. Thanks, Walter

> I also noticed, that kspaceFirstOrderxD mutates its inputs, which is not the case in the matlab version. Is this your desired behaviour? If you run e.g. the at_array_as_sensor example...

Feel free to make a new file called `test_simulation.py` in `k-wave-python/tests/`. Have a look at `k-wave-python/tests/test_checks.py` and `k-wave-python/tests/test_executor.py` for inspiration. Let me know if you have any other questions! Thanks!

Hey @faberno, until now, we have not run simulations in the CI but mocked inputs and outputs. That is why the dependencies for the executables are not found and failing....

> I also noticed, that kspaceFirstOrderxD mutates its inputs, which is not the case in the matlab version. Is this your desired behaviour? If you run e.g. the at_array_as_sensor example...

@brubbel Thanks for reporting this. Please look at [the relicensing we began this past week](https://github.com/waltsims/k-wave-python/discussions/525). We need your input to move forward.

Hi @brubbel, Just following up [on the relicensing issue](https://github.com/waltsims/k-wave-python/discussions/525). Please follow the steps there so we can move forward. Feel free to contact me via e-mail if you have any...

overengineered

[https://github.com/waltsims/kspaceFirstOrder-CUDA-linux/blob/main/Parameters/Parameters.h#L102-L110](https://github.com/waltsims/kspaceFirstOrder-CUDA-linux/blob/main/Parameters/Parameters.h#L102-L110) Absorption parameters can be found here