Richard Wall

Bring back addFailureFields or a way to log information only when an action (or sub-action) fails

2

Eliot used to have addFailureFields - https://github.com/ClusterHQ/eliot/blob/0.3.0/eliot/_action.py#L274 But it was removed for want of a use case. Here's one: In Flocker we'd like to be able to log the entire...

I was puzzled to see journald tests skipped on my Fedora 23 laptop. ``` [SKIPPED] journald unavailable or inactive on this machine. eliot.tests.test_journald.JournaldDestinationTests.test_action_type ``` I'd only done `pip install --editable...

Eliot documentation theme is deprecated

1

Sphinx prints this warning while building the Eliot docs ``` WARNING: 'default' html theme has been renamed to 'classic'. Please change your html_theme setting either to the new 'alabaster' default...

Here are some examples. ``` diff diff --git a/docs/source/types-testing.rst b/docs/source/types-testing.rst index 517c85d..9c68add 100644 --- a/docs/source/types-testing.rst +++ b/docs/source/types-testing.rst @@ -15,27 +15,24 @@ Let's unit test some code that relies on the...

Compilation error on Alpine Linux

1

When I attempt to install `ncurses-ruby` in a `ruby:2.4-alpine` Docker container there is a compilation error. See the following Python issues which report similar problem and a solution. * https://github.com/python-pillow/Pillow/issues/1850...

WIP: Only remove the cleanup finalizer if the cleanup succeeds

20

This addresses two problems: * The finalizer was being removed unconditionally, regardless of whether solver.Cleanup succeeds * The finalizer was assumed to be the first in the list of finalizers,...

WIP: Generate applyconfigurations and Apply functions

7

```release-note NONE ```

Certificate.Spec.RenewEvery instead of RenewBefore

7

I want to be able to configure cert-manager to renew my Certificate every 1h, regardless of the NotBefore and NotAfter fields of the TLS certificate returned by the CA. Currently...

Venafi unit-test are flakey when run via make

1

The venafi unit-tests failed in CI. But passed locally for me: * https://prow.build-infra.jetstack.net/view/gs/jetstack-logs/pr-logs/pull/cert-manager_cert-manager/5051/pull-cert-manager-make-test/1519248618677080064 ``` $ go test ./pkg/controller/certificaterequests/venafi -v ... --- PASS: TestSign (2.62s) --- PASS: TestSign/tpp:_if_fail_to_build_client_based_on_missing_secret_then_return_nil_and_hard_fail (0.16s) --- PASS:...

Allow multiple transform operations to be performed before checking invariants

2

(I think this is basically the same issue that @tomprince reported in https://github.com/tobgu/pyrsistent/issues/73 but I can't re-open that issue.) Here's a use case: In https://github.com/ClusterHQ/flocker/pull/2806 we introduced a mechanism for...