Richard Wall

Results 179 comments of Richard Wall

The API might look something like the `addDetail` feature in testtools. - https://testtools.readthedocs.org/en/latest/for-test-authors.html#details

Twisted has `testutils.ComparisonTestsMixin.assertNormalEqualityImplementation` https://github.com/twisted/twisted/blob/trunk/twisted/test/testutils.py#L125 - Are all those assertions strictly necessary? - Should we aim to generate a TestCase class which has separate test methods for all those assertions? -...

/priority important-soon Assigned during triage party. Seems like this will be embarked on during the next few months of GSoC.

I think it might be worth going one step further and doing a dry-run by default and adding a `--no-dry-run` flag. That way someone who is playing around with cmctl...

Thanks for sharing the logs. We could consider adding a new field to the Issuer to override the default 10s timeout. I notice from that source file you linked, that...

@inteon I discovered that you can also use label selectors in `kubectl create / apply` so these commands might also help: ```sh # All non-crds (CRDs don't have a component...

Some more ideas which might avoid complicating the secretTemplate validation logic: 1. Workaround: You could pre-create a Secret with the `cert-manager.io/allow-direct-injection` annotation and refer to that in your Certificate. Then...

Thanks @irbekrm I assume that I've somehow managed to break tons of E2E tests with this additional change, but I haven't quite figured out what I've changed. I'm working on...