Tom Walker

Results 11 comments of Tom Walker

@dpetersen, @Bregor, @redondos or @grobie, do one of you have the time to review this change please? Thanks in advance.

@marselsultanov I think you are correct and the solution is as you laid out below. > If i change: > > 1. values.yaml to > > ``` > extraManifests: >...

Closing this as it has been resolved in #4043, if you have any further problems or feature requests please open a new issue, thanks!

> Don't mean to necro this, but is the intended way to use this to add an `--config.file=foo` as an `extraArgs` value? For anyone finding this that's what I ended...

> Hi @walker-tom I've fixed the merge conflict. Do you need me to do anything else? > > Thanks, Brian Hi Brian, thanks for updating your PR, could you update...

Thanks for the suggestion, looking at when this was done for the `prometheus` chart in https://github.com/prometheus-community/helm-charts/pull/3133, it shouldn't be too difficult to change. I'll look to get this changed or...

@abctaylor You will need to create an `auths` configuration for your targets in your SNMP Exporter. As documented in [auth-split-migration.md](https://github.com/prometheus/snmp_exporter/blob/main/auth-split-migration.md) this is now separate to the `modules` configuration. You can...

> `hack/update-codegen.sh` needs to be run to generate the docs. > > /kind documentation /cc @sftim It seems to be valid https://kubernetes.io/docs/reference/kubernetes-api/workload-resources/pod-v1/. I've run `hack/update-codegen.sh` but there were no additional...

@pacoxu / @sftim are either of you able to re-review please? Thanks