helm-charts icon indicating copy to clipboard operation
helm-charts copied to clipboard

[prometheus-snmp-exporter] migrate to quay.io/prometheus-operator/prometheus-config-reloader

Open freedge opened this issue 1 year ago • 1 comments

Is your feature request related to a problem ?

as in https://github.com/prometheus-community/helm-charts/issues/415,

unlike the other charts that moved to quay.io/prometheus-operator/prometheus-config-reloader, snmp-exporter is still using jimmidyson/configmap-reload

Describe the solution you'd like.

move to quay.io/prometheus-operator/prometheus-config-reloader

Describe alternatives you've considered.

staying with the non official jimmidyson from docker.io

Additional context.

No response

freedge avatar Sep 23 '23 14:09 freedge

Thanks for the suggestion, looking at when this was done for the prometheus chart in https://github.com/prometheus-community/helm-charts/pull/3133, it shouldn't be too difficult to change. I'll look to get this changed or feel free to submit a PR for me to review.

walker-tom avatar Feb 22 '24 14:02 walker-tom

Hi @walker-tom, I created a PR for this issue, please review. This is my first issue 😄 please tell me if there is something that needs to change.

MohammadrezaTavakoli avatar Feb 27 '24 12:02 MohammadrezaTavakoli

Fixed in #4304, thanks @MohammadrezaTavakoli!

walker-tom avatar Feb 29 '24 05:02 walker-tom