Vasily Martynov comments

Results 60 comments of


                                            Vasily Martynov

WSSecurity Protocol with user/pass token element.

No objections on this PR, tests passed, merging.

fix: invalid multipart/related Content-Type

Hi @sandrozbinden-axa, when do you need this change?

fix: invalid multipart/related Content-Type

@benasher44 I don't think I have permissions to enable issues tab. I will ask project owner if I remember about it.

fix: invalid multipart/related Content-Type

@sandrozbinden-axa I will have a look on other changes that may be included into next release. Feel free to suggest pull-requests that maybe useful. I will try to release new...

feat: add express request object as parameter to the log method.

Looks good to me, thanks for the readme update. I will merge it when will be preparing new release.

fix: updated xml-crypto package to 2.1.5

I am working on updating xml-crypto to version 6. Closing this PR.

Bumped xml-crypto version to ">=4.0.1"

Hi @parallels999, if you can update it to version 6, I am happy to review and merge it. Thanks.

Bumped xml-crypto version to ">=4.0.1"

I am testing new changes with updated deps, including xml-crypto 6. Closing this PR as it is inactive.

Try to make error messages useful when using SOAP 1.2

Yeah, this makes sense, approved, I will merge when will be preparing new release. Thanks for the improvement.

Speed up WSDL parsing

Changes look good. I guess you run some performance tests, how much faster parsing now?