Vasily Martynov comments

Results 62 comments of


                                            Vasily Martynov

update axios version

Hi All, I will be helping to maintain this project for some time, discussing details with @vpulim atm. Hopefully I will release this soon.

fix: Add space after `xmlns:wsu` to prevent xmldom warning

I don't see any problem with this change, tried locally and all tests passed.

Improve trim speed during XML parsing.

Good one, thanks for submitting it, I will include in the next release.

Change axios back as dependency.

New version has been released. I guess this PR is not relevant anymore? Please let me know if this is still an issue.

Change axios back as dependency.

Do you still use old npm versions? My team is on the latest node and npm so I can't really say how important this is.

Change axios back as dependency.

Thanks for detailed response @KrayzeeKev. I don't see any problems to make it normal dependency. At least it does not look like it should introduce any problems. Do you mind...

Change axios back as dependency.

I raised another PR as it was easier https://github.com/vpulim/node-soap/pull/1237 Please comment there if you have any objections, otherwise I will include it into next release.

Change axios back as dependency.

Change is accepted and merged in https://github.com/vpulim/node-soap/pull/1237

Bumped Axios version to ">=0.25.0"

Should not be problem anymore, new version released with updated axios.

WSSecurity Protocol with user/pass token element.

I resolved conflict and seemed like it works. Wondering if @jsdevel wants to review it again? I personally don't see any problem merging it.